daemon: Improve error msg for endpoint IP reallocation #10494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when restoring endpoints, if the reallocation of an IP addr
of an endpoint failed, the error log message didn't include that IP.
E.g.:
level=warning msg="Unable to restore endpoint, ignoring" endpointID=2930
error="Failed to re-allocate IP of endpoint: unable to reallocate IPv6
address: provided IP is not in the valid range. The range of valid IPs
is f00d::a0c:0:0:0/96" k8sPodName=default/testds-l87pp subsys=daemon
This commit includes IP addr in the error msg for a better troubleshooting.
Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
pending-review
area/daemon
|
test-me-please |
|
test-me-please |
pchaigno
approved these changes
Mar 6, 2020
joestringer
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when restoring endpoints, if the reallocation of an IP addr of an endpoint failed, the error log message didn't include that IP. E.g.:
This commit includes IP addr in the error msg for a better troubleshooting.
This change is