Helm-charts: Fix the values.yaml comment that was misleading #10515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit ed65571c0cb2dc504bb28b40a9b60df64998af9b does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
|
Release note label not set, please set the appropriate release note. |
1 similar comment
|
Release note label not set, please set the appropriate release note. |
joestringer
approved these changes
Mar 9, 2020
|
@soumynathan FYI you can use |
joestringer
added
the
release-note/misc
This patch fixes the values.yaml comment for the 'ipvlan' related key (primaryDevice instead of masterDevice) that mismatches with the code and the documentation. Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
soumynathan
force-pushed
the
fix-default-values-comment-in-cilium
branch
from
ed65571
to
99a2898
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the values.yaml comment for the 'ipvlan'
related key (primaryDevice instead of masterDevice) that mismatches
with the code and the documentation.
Singed-off-by: Swaminathan Vasudevan svasudevan@suse.com
This change is