Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/bpf: remove unused (Get|Set)MapPrefix funcs #10529

Merged
merged 1 commit into from Mar 11, 2020
Merged

pkg/bpf: remove unused (Get|Set)MapPrefix funcs #10529

merged 1 commit into from Mar 11, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Mar 10, 2020 •
edited

Also unexport SetMapRoot since it's not used outside the package.

This change is Reviewable

@tklauser
pkg/bpf: remove unused (Get|Set)MapPrefix funcs
6efdd27 
Also unexport SetMapRoot since it's not used outside the package.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Mar 10, 2020
@tklauser tklauser requested a review from a team March 10, 2020 13:49
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 10, 2020
@tklauser
Copy link
Member Author

tklauser commented Mar 10, 2020 •
edited

test-me-please

failure: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17833/

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 45.622% when pulling 6efdd27 on pr/tklauser/bpf-remove-unused into 0dc12fb on master.

@tklauser
Copy link
Member Author

tklauser commented Mar 10, 2020 •
edited

test-me-please

provisioning failure https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17841/

@tklauser
Copy link
Member Author

tklauser commented Mar 10, 2020 •
edited

test-me-please

previous failure: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17847/ looks like #10447

@joestringer
Copy link
Member

I filed this issue for the flake seen in the first failure link:

#10538

@tklauser please consider doing this in future if you observe failures that seem unrelated to your changes. It helps other developers see issues that may flake out and affect development in general as the flakes are searchable and we can track how often they hit, whether they're being investigated, etc.

@tklauser
Copy link
Member Author

@tklauser please consider doing this in future if you observe failures that seem unrelated to your changes. It helps other developers see issues that may flake out and affect development in general as the flakes are searchable and we can track how often they hit, whether they're being investigated, etc.

Thanks, will do.

@tklauser
Copy link
Member Author

test-me-please

@tklauser tklauser mentioned this pull request Mar 11, 2020
Closed
@tgraf tgraf merged commit 0f393a3 into master Mar 11, 2020
1.8.0 automation moved this from In progress to Merged Mar 11, 2020
@tgraf tgraf deleted the pr/tklauser/bpf-remove-unused branch March 11, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @coveralls @joestringer @qmonnet @tgraf