Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPAM cleanups #10535

Merged
merged 3 commits into from Mar 13, 2020
Merged

IPAM cleanups #10535

merged 3 commits into from Mar 13, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Mar 10, 2020 •
edited

Various cleanups to prepare for the addition of additional IPAM modes

This change is Reviewable

@tgraf tgraf added pending-review kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Mar 10, 2020
@tgraf tgraf requested review from a team as code owners March 10, 2020 18:31
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

3 similar comments
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 10, 2020
houndci-bot
houndci-bot reviewed Mar 10, 2020
View reviewed changes
pkg/azure/ipam/instances.go Outdated Show resolved Hide resolved
pkg/azure/ipam/instances.go Outdated Show resolved Hide resolved
houndci-bot
houndci-bot reviewed Mar 10, 2020
View reviewed changes
pkg/azure/ipam/instances.go Outdated Show resolved Hide resolved
pkg/azure/ipam/instances.go Outdated Show resolved Hide resolved
@tgraf tgraf added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Mar 10, 2020
@tgraf
Move PoolID and PoolQuota to pkg/ipam/types
aaec070 
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
ipam: Use cidr.CIDR in types.Subnet
4ee180b 
This avoids parsing the CIDR string in deeper logic and forces parsing
at creation of types.Subnet.

Signed-off-by: Thomas Graf <thomas@cilium.io>
houndci-bot
houndci-bot reviewed Mar 11, 2020
View reviewed changes
pkg/ipam/allocator/allocator.go Show resolved Hide resolved
pkg/azure/ipam/instances.go Outdated Show resolved Hide resolved
houndci-bot
houndci-bot reviewed Mar 11, 2020
View reviewed changes
pkg/ipam/allocator/noop.go Show resolved Hide resolved
pkg/ipam/allocator/allocator.go Show resolved Hide resolved
pkg/azure/ipam/instances.go Outdated Show resolved Hide resolved
@tgraf tgraf force-pushed the pr/tgraf/ipam-cleanups branch 2 times, most recently from 2e6a2c4 to 0319d57 Compare March 11, 2020 11:07
@tgraf
Copy link
Member Author

tgraf commented Mar 11, 2020 •
edited

test-me-please

EDIT: green build

@tgraf
ipam: Factour out subnet-based pool allocator
61a3124 
The allocation logic to allocate from a set of subnets will be used in
additional IPAM modes. Factor it out.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 45.676% when pulling 61a3124 on pr/tgraf/ipam-cleanups into 6d29bba on master.

@tgraf
Copy link
Member Author

tgraf commented Mar 11, 2020

test-me-please

@tgraf tgraf merged commit ac74aea into master Mar 13, 2020
1.8.0 automation moved this from In progress to Merged Mar 13, 2020
@tgraf tgraf deleted the pr/tgraf/ipam-cleanups branch March 13, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tgraf @coveralls @aanm @houndci-bot