Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.travis: delete allow_failures for Arm64 job #10540

Merged
merged 1 commit into from Mar 11, 2020
Merged

.travis: delete allow_failures for Arm64 job #10540

merged 1 commit into from Mar 11, 2020

Conversation

Jianlin-lv
Copy link
Contributor

@Jianlin-lv Jianlin-lv commented Mar 11, 2020 •
edited by tgraf

Signed-off-by: Jianlin Lv Jianlin.Lv@arm.com

Related: #9898

This change is Reviewable

@Jianlin-lv
.travis: delete allow_failures for Arm64 job
1fa048a 
Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
@Jianlin-lv Jianlin-lv requested a review from a team as a code owner March 11, 2020 03:20
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 11, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 45.651% when pulling 1fa048a on Jianlin-lv:pr-disable-allow_failures into e43c2ff on cilium:master.

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Mar 11, 2020
joestringer
joestringer approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to pass, so LGTM.

@joestringer joestringer merged commit d43afa4 into cilium:master Mar 11, 2020
1.8.0 automation moved this from In progress to Merged Mar 11, 2020
@Jianlin-lv Jianlin-lv deleted the pr-disable-allow_failures branch March 11, 2020 12:45
@tklauser tklauser mentioned this pull request Mar 20, 2020
Merged
tklauser added a commit that referenced this pull request Mar 20, 2020
@tklauser
Travis CI: delete allow_failures for arm64 job from template
5a643fe 
PR #10540 deleted `allow_failures` from `.travis.yml` but not from
`.travis.yml.tmpl`. This leads to `allow_failures` being added again
when running `make update-travis-go-version`.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
aanm pushed a commit that referenced this pull request Mar 20, 2020
@tklauser @aanm
Travis CI: delete allow_failures for arm64 job from template
d28d1b9 
PR #10540 deleted `allow_failures` from `.travis.yml` but not from
`.travis.yml.tmpl`. This leads to `allow_failures` being added again
when running `make update-travis-go-version`.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@joestringer joestringer added this to Done in ARM64 support Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
ARM64 support
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jianlin-lv @coveralls @joestringer