Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Declare config. variables as volatile #10557

Merged
merged 1 commit into from Mar 12, 2020
Merged

bpf: Declare config. variables as volatile #10557

merged 1 commit into from Mar 12, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Mar 12, 2020 •
edited by tgraf

This commit declares config. variables as volatile to prevent the compiler from optimizing code based on the value of those variables if/when we start using them in conditions. Declaring them as volatile does not currently result in any changes in the generated bytecodes.

This change is Reviewable

@pchaigno
bpf: Declare config. variables as volatile
e088d9b 
This commit declares config. variables as volatile to prevent the
compiler from optimizing code based on the value of those variables.
Declaring them as volatile does not currently result in any changes in
the generated bytecodes.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Mar 12, 2020
@pchaigno pchaigno requested review from borkmann, joestringer and a team March 12, 2020 12:07
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 12, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 45.659% when pulling e088d9b on pr/pchaigno/bpf-volatile-static-data into f1f29c0 on master.

@pchaigno
Copy link
Member Author

test-me-please

@qmonnet
Copy link
Member

qmonnet commented Mar 12, 2020

test-me-please

@joestringer
Copy link
Member

I filed #10565 for the flake, doesn't seem related to this PR and it only flaked on kube-proxy-free run.

@joestringer joestringer merged commit 79e1f3e into master Mar 12, 2020
1.8.0 automation moved this from In progress to Merged Mar 12, 2020
@joestringer joestringer deleted the pr/pchaigno/bpf-volatile-static-data branch March 12, 2020 19:54
@joestringer
Copy link
Member

/cc @lzang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@joestringer joestringer joestringer approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @coveralls @qmonnet @joestringer @borkmann