New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: Pick up the latest cilium/hubble #10563
Conversation
Release note label not set, please set the appropriate release note. |
e1b2678
to
ffbab7e
Compare
97288a7
to
3ee5d6f
Compare
Coverage decreased (-0.004%) to 45.613% when pulling 3ee5d6f0e906094df300fef76e645503eead38ec on pr/michi/hubble into a734d81 on master. |
- Adapt to the new option pattern to configure hubble server. - Pass the daemon context to hubble server and monitor listener. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
3ee5d6f
to
02c5378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of the removed vendor dependencies from go.mod
relevant to this change?
github.com/docker/go-connections
github.com/envoyproxy/protoc-gen-validatd
github.com/morikuni/aec
@joestringer most likely not, but probably makes sense to include it. this change is going to happen when somebody runs |
Hmm, okay, it seems like it must be related to the changes made here because on master *shrug |
yeah sorry this go mod thing is still a bit of a mystery to me. |
test-me-please |
Signed-off-by: Michi Mutsuzaki michi@isovalent.com
This change is