Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Pick up the latest cilium/hubble #10563

Merged
merged 1 commit into from Mar 13, 2020
Merged

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Mar 12, 2020

Signed-off-by: Michi Mutsuzaki michi@isovalent.com


This change is Reviewable

@michi-covalent michi-covalent requested a review from a team March 12, 2020 16:17
@michi-covalent michi-covalent requested review from a team as code owners March 12, 2020 16:17
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 12, 2020
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Mar 12, 2020
@michi-covalent
Copy link
Contributor Author

cc @glibsm @rolinh

daemon/daemon_main.go Outdated Show resolved Hide resolved
@michi-covalent michi-covalent force-pushed the pr/michi/hubble branch 2 times, most recently from 97288a7 to 3ee5d6f Compare March 12, 2020 17:18
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 45.613% when pulling 3ee5d6f0e906094df300fef76e645503eead38ec on pr/michi/hubble into a734d81 on master.

daemon/daemon_main.go Outdated Show resolved Hide resolved
- Adapt to the new option pattern to configure hubble server.
- Pass the daemon context to hubble server and monitor listener.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of the removed vendor dependencies from go.mod relevant to this change?

github.com/docker/go-connections
github.com/envoyproxy/protoc-gen-validatd
github.com/morikuni/aec

@michi-covalent
Copy link
Contributor Author

@joestringer most likely not, but probably makes sense to include it. this change is going to happen when somebody runs go mod tidy the next time anyways.

@joestringer
Copy link
Member

Hmm, okay, it seems like it must be related to the changes made here because on master go mod tidy doesn't remove these, but if I check out your changes and restore those lines to the go.mod, go mod tidy removes them again.

*shrug

@michi-covalent
Copy link
Contributor Author

yeah sorry this go mod thing is still a bit of a mystery to me.

@joestringer
Copy link
Member

test-me-please

@joestringer joestringer merged commit a5c0488 into master Mar 13, 2020
1.8.0 automation moved this from In progress to Merged Mar 13, 2020
@joestringer joestringer deleted the pr/michi/hubble branch March 13, 2020 22:09
@rolinh rolinh added the sig/hubble Impacts hubble server or relay label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants