Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf, sock: avoid allocating cilium_lb6_reverse_sk if v6 is disabled #10573

Merged
merged 1 commit into from Mar 13, 2020
Merged

bpf, sock: avoid allocating cilium_lb6_reverse_sk if v6 is disabled #10573

merged 1 commit into from Mar 13, 2020

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented Mar 13, 2020 •
edited by tgraf

The map is not being used for v4-in-v6 when v6 is disabled. By not
allocating the map we save 13M of unnecessary memory overhead.

Fixes: #10571
Signed-off-by: Daniel Borkmann daniel@iogearbox.net

This change is Reviewable

@borkmann borkmann added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Mar 13, 2020
@borkmann borkmann requested review from brb, aanm and a team March 13, 2020 13:08
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

2 similar comments
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 13, 2020
@borkmann borkmann added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note labels Mar 13, 2020
@borkmann
Copy link
Member Author

test-me-please

@borkmann
bpf, sock: avoid allocating cilium_lb6_reverse_sk if v6 is disabled
04cf05f 
The map is not being used for v4-in-v6 when v6 is disabled. By not
allocating the map we save 13M of unnecessary memory overhead.

Fixes: #10571
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented Mar 13, 2020 •
edited

Coverage Status

Coverage increased (+0.01%) to 45.664% when pulling 04cf05f on pr/bpf-sock-v6-map into ac74aea on master.

@borkmann borkmann merged commit cbd90bd into master Mar 13, 2020
1.8.0 automation moved this from In progress to Merged Mar 13, 2020
@borkmann borkmann deleted the pr/bpf-sock-v6-map branch March 13, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@aanm aanm aanm approved these changes

@brb brb Awaiting requested review from brb

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cilium_cgroups_connect6 is created even with "enable-ipv6=false"
4 participants
@borkmann @coveralls @tklauser @aanm