Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix configuring the Cilium agent in dev VM #10578

Merged
merged 1 commit into from Mar 17, 2020
Merged

test: Fix configuring the Cilium agent in dev VM #10578

merged 1 commit into from Mar 17, 2020

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Mar 13, 2020 •
edited

The helpers file was assuming that the test path is mounted into the
target VM at the location "/vagrant", but this is not the case for the
developer VM so if you attempt to run the ginkgo runtime CI against the
dev VM you'll hit this error:

  Expected
      <*errors.errorString | 0xc0004b0900>: {
          s: "cp: cannot stat '/vagrant/cilium': No such file or directory\n",
      }
  to be nil

This change is Reviewable

@joestringer
test: Fix configuring the Cilium agent
0186326 
The helpers file was assuming that the test path is mounted into the
target VM at the location "/vagrant", but this is not the case for the
developer VM so if you attempt to run the ginkgo runtime CI against the
dev VM you'll hit this error:

  Expected
      <*errors.errorString | 0xc0004b0900>: {
          s: "cp: cannot stat '/vagrant/cilium': No such file or directory\n",
      }
  to be nil

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer added wip release-note/ci This PR makes changes to the CI. labels Mar 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 13, 2020
@joestringer
Copy link
Member Author

joestringer commented Mar 13, 2020 •
edited

test-me-please

EDIT: Provisioning failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17899/

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 45.677% when pulling 0186326 on joestringer:submit/fix-ginkgo-dev-vm into ba0b078 on cilium:master.

@joestringer
Copy link
Member Author

test-me-please

@joestringer
Copy link
Member Author

Runtime tests pass, and these changes only affect runtime tests. Ready to review.

@joestringer joestringer marked this pull request as ready for review March 13, 2020 22:26
@joestringer joestringer requested a review from a team as a code owner March 13, 2020 22:26
@joestringer joestringer changed the title test: Fix configuring the Cilium agent test: Fix configuring the Cilium agent in dev VM Mar 13, 2020
@joestringer
Copy link
Member Author

test-me-please

@tgraf tgraf merged commit 44fa06a into cilium:master Mar 17, 2020
1.8.0 automation moved this from In progress to Merged Mar 17, 2020
@joestringer joestringer deleted the submit/fix-ginkgo-dev-vm branch March 18, 2020 02:55
@pchaigno pchaigno mentioned this pull request Jun 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joestringer @coveralls @tgraf