Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Upgrade MarkupSafe to 1.1.1 #10579

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

vadorovsky
Copy link
Member

@vadorovsky vadorovsky commented Mar 13, 2020

Installing MarkupSafe 1.0.0 with setuptools 44.0.0 results in the
following error:

Complete output (5 lines):
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/pip-install-0jhff9bc/MarkupSafe/setup.py", line 6, in <module>
    from setuptools import setup, Extension, Feature
ImportError: cannot import name 'Feature' from 'setuptools'

Upgrading MarkupSafe to 1.1.1 solves the problem.

Signed-off-by: Michal Rostecki mrostecki@opensuse.org


This change is Reviewable

Installing MarkupSafe 1.0.0 with setuptools 44.0.0 results in the
following error:

  Complete output (5 lines):
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-install-0jhff9bc/MarkupSafe/setup.py", line 6, in <module>
      from setuptools import setup, Extension, Feature
  ImportError: cannot import name 'Feature' from 'setuptools'

Upgrading MarkupSafe to 1.1.1 solves the problem.

Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
@vadorovsky vadorovsky added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 13, 2020
@vadorovsky vadorovsky requested a review from a team as a code owner March 13, 2020 20:22
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 13, 2020
@vadorovsky
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 45.658% when pulling c981002 on mrostecki:markupsafe-update into ba0b078 on cilium:master.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.2 Mar 13, 2020
@joestringer
Copy link
Member

Nominating for 1.7 backport just because we'll be building docs there for quite a while yet so if it makes fixing those docs any easier for developers, it's probably worthwhile.

@joestringer joestringer merged commit 7a4e2bf into cilium:master Mar 13, 2020
1.8.0 automation moved this from In progress to Merged Mar 13, 2020
@vadorovsky vadorovsky deleted the markupsafe-update branch March 14, 2020 12:12
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.2 Mar 16, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.2 Mar 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.2 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.7.2
Backport done to v1.7
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants