Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix documentation postchecks #10585

Merged
merged 1 commit into from Mar 16, 2020
Merged

docs: Fix documentation postchecks #10585

merged 1 commit into from Mar 16, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Mar 16, 2020

The Runtime* tests are failing with the following error.

 runtime: make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/cilium/Documentation'
runtime: diff -x '*.rst' -r ./Documentation/cmdref/cilium-agent.md /tmp/tmp.TrZz6y7HNu/cilium-agent.md
runtime: 52d51
runtime: <       --disable-k8s-services                          Disable east-west K8s load balancing by cilium
runtime: Detected a difference in the cmdref directory
runtime: diff -r: diff -r ./Documentation/cmdref/cilium-agent.md /tmp/tmp.TrZz6y7HNu/cilium-agent.md
runtime: 52d51
runtime: <       --disable-k8s-services                          Disable east-west K8s load balancing by cilium
runtime: Only in ./Documentation/cmdref: cli_index.rst
runtime: Only in ./Documentation/cmdref: index.rst
runtime: Only in ./Documentation/cmdref: kvstore.rst
runtime: Please rerun 'make -C Documentation cmdref' and commit your changes
runtime: Makefile:456: recipe for target 'postcheck' failed
runtime: make: *** [postcheck] Error 1

Fixes: #10552

/cc @soumynathan


This change is Reviewable

The Runtime* tests are failing with the following error.

  runtime: make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/cilium/Documentation'
  runtime: diff -x '*.rst' -r ./Documentation/cmdref/cilium-agent.md /tmp/tmp.TrZz6y7HNu/cilium-agent.md
  runtime: 52d51
  runtime: <       --disable-k8s-services                          Disable east-west K8s load balancing by cilium
  runtime: Detected a difference in the cmdref directory
  runtime: diff -r: diff -r ./Documentation/cmdref/cilium-agent.md /tmp/tmp.TrZz6y7HNu/cilium-agent.md
  runtime: 52d51
  runtime: <       --disable-k8s-services                          Disable east-west K8s load balancing by cilium
  runtime: Only in ./Documentation/cmdref: cli_index.rst
  runtime: Only in ./Documentation/cmdref: index.rst
  runtime: Only in ./Documentation/cmdref: kvstore.rst
  runtime: Please rerun 'make -C Documentation cmdref' and commit your changes
  runtime: Makefile:456: recipe for target 'postcheck' failed
  runtime: make: *** [postcheck] Error 1

Fixes: #10552
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added pending-review area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Mar 16, 2020
@pchaigno pchaigno requested a review from a team as a code owner March 16, 2020 10:17
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 16, 2020
@pchaigno
Copy link
Member Author

test-docs-please

@brb brb merged commit cfd334c into master Mar 16, 2020
1.8.0 automation moved this from In progress to Merged Mar 16, 2020
@brb brb deleted the pr/pchaigno/fix-doc-test branch March 16, 2020 10:38
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 45.651% when pulling 1297c8f on pr/pchaigno/fix-doc-test into c5a33aa on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants