daemon/cmd: update visibility policy after endpoint queue is created #10608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
kind/bug
|
Release note label not set, please set the appropriate release note. |
4 similar comments
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
aanm
added
the
release-note/bug
|
test-me-please previous flake https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17976/ |
joestringer
reviewed
Mar 17, 2020
joestringer
reviewed
Mar 17, 2020
There was a problem hiding this comment.
Just one question below on potentially queueing multiple regenerations. I'm concerned this may affect all endpoints, not just endpoints with the annotations.
EDIT: Github did weird things. I mean the above comment:
#10608 (review)
joestringer
approved these changes
Mar 17, 2020
|
test-me-please |
As the endpoint queue is created when adding the endpoint to the endpoint manager we should only update the visibility policy after the endpoint is added to the endpoint manager to avoid seeing error logs every time a new endpoint is created. Fixes: acbf880 ("pkg/endpoint: decrease direct iteractions with k8s-apiserver") Signed-off-by: André Martins <andre@cilium.io>
|
test-me-please |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the endpoint queue is created when adding the endpoint to the
endpoint manager we should only update the visibility policy after the
endpoint is added to the endpoint manager to avoid seeing error logs
every time a new endpoint is created.
Fixes: acbf880 ("pkg/endpoint: decrease direct iteractions with k8s-apiserver")
Signed-off-by: André Martins andre@cilium.io
Fixes #10543
This change is