Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: include branch name in file generated by start-backport #10649

Merged
merged 1 commit into from Mar 20, 2020
Merged

contrib: include branch name in file generated by start-backport #10649

merged 1 commit into from Mar 20, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Mar 20, 2020

When working on backports to different branches, the generated file was being overwritten as its name consisted of only the current date. This commit changes the generated file name to also include information about the branch/release in the file name to prevent this issue.

@rolinh
contrib: include branch name in file generated by start-backport
c7e5790 
When working on backports to different branches, the generated file was
being overwritten as its name consisted of only the current date.
This commit changes the generated file name to also include information
about the branch/release in the file name to prevent this issue.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Mar 20, 2020
@rolinh rolinh requested review from a team as code owners March 20, 2020 09:50
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 20, 2020
@rolinh rolinh mentioned this pull request Mar 20, 2020
Merged
@rolinh rolinh requested a review from joestringer March 20, 2020 09:52
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 45.598% when pulling c7e5790 on pr/rolinh/contrib-backport-start-branch-name into 84dd81c on master.

@rolinh
Copy link
Member Author

rolinh commented Mar 20, 2020

test-me-please

@joestringer joestringer merged commit c9f0d24 into master Mar 20, 2020
1.8.0 automation moved this from In progress to Merged Mar 20, 2020
@joestringer joestringer deleted the pr/rolinh/contrib-backport-start-branch-name branch March 20, 2020 16:38
@joestringer joestringer mentioned this pull request Jul 9, 2020
Merged
@joestringer joestringer added this to Backport pending to v1.6 in 1.6.11 Jul 9, 2020
@joestringer joestringer moved this from Backport pending to v1.6 to Backport done to v1.6 in 1.6.11 Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.6.11
Backport done to v1.6
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rolinh @coveralls @joestringer @vadorovsky