daemon: Handle ClusterIP svc if kube-proxy-replacement=disabled #10651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got a few reports from confused users saying that setting "--kube-proxy-replacement" to "disabled" disabled ClusterIP services handling done by Cilium regardless whether "--disable-k8s-services" was set to "false". This is an expected behavior for us, but probably less expected for users who previously had the ClusterIP handling enabled by default due to "--disable-k8s-services" defaulting to "false". To minimize the confusion, handle ClusterIP services with the old mechanism (pre-v1.6) even if the "--kube-proxy-replacement" is set to "disabled". Once we deprecate the "--disable-k8s-services" flag (in v1.9), we can disable handling of all types of services with the former flag. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
pending-review
area/documentation
|
test-me-please |
|
test-docs-please |
aanm
approved these changes
Mar 20, 2020
|
@brb please add a user-friendly release note |
borkmann
approved these changes
Mar 20, 2020
aanm
added
release-note/minor
|
test-me-please |
joestringer
approved these changes
Mar 20, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a few reports from confused users saying that setting
"--kube-proxy-replacement" to "disabled" disabled ClusterIP
services handling done by Cilium regardless whether
"--disable-k8s-services" was set to "false".
This is an expected behavior for us, but probably less expected
for users who previously had the ClusterIP handling enabled by default
due to "--disable-k8s-services" defaulting to "false".
To minimize the confusion, handle ClusterIP services with the old
mechanism (pre-v1.6) even if the "--kube-proxy-replacement" is set to
"disabled". Once we deprecate the "--disable-k8s-services" flag (in v1.9),
we can disable handling of all types of services with the former flag.