vagrant: Improvements to provisioning #10660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
pending-review
area/misc
pchaigno
commented
Mar 23, 2020
| @@ -8,7 +8,9 @@ popd > /dev/null | |||
|
|
|||
There was a problem hiding this comment.
For reviewers: It looks like this file is actually only used for the dev. VM provisioning. Should it be moved to contrib/vagrant/scripts/?
pchaigno
force-pushed
the
pr/pchaigno/vagrant-provisioning-improvements
branch
from
eceb96d
to
0319903
Compare
aanm
approved these changes
Mar 23, 2020
qmonnet
reviewed
Mar 23, 2020
pchaigno
force-pushed
the
pr/pchaigno/vagrant-provisioning-improvements
branch
from
0319903
to
f9d0cf7
Compare
qmonnet
approved these changes
Mar 24, 2020
During VM provisioning, we cache some downloaded files outside the VM, to speed up subsequent provisionings. If a cached file is present we consider that it's safe to reuse. That is however not the case when the download was interrupted (e.g., because of a network error or because VM provisioning was interrupted). Ideally we would check the signature of downloaded files, but the associated projects have different ways of exposing the signatures. This commit changes download_to() to download files in /tmp and move them to the cache only once the download is succesfull. This behavior requires the use of 'set -e'. The cache may still end with partial files if provisioning is interrupted while the file is moved out of /tmp. That operation is however much faster than the download and an interruption therefore less likely. Signed-off-by: Paul Chaignon <paul@cilium.io>
Those binaries are a few MB large and caching them cuts a few seconds from the total provisioning time. Signed-off-by: Paul Chaignon <paul@cilium.io>
Currently, when an installation is interrupted during the first provisioning of the dev. VM, the VM must be destroyed and recreated. Otherwise, because the VM is already up, start.sh assumes that e.g. Kubernetes is already installed. This new env. variable allows us to force a new installation. It is still only useful to restart interrupted installations as it will fail to re-install a successful installation (some files are curently locked while used by Kubernetes). Signed-off-by: Paul Chaignon <paul@cilium.io>
When provisioning the dev. VM, Cilium is currently build from scratch every time. This is often unnecessary. This commit removes the 'make clean' operation before building Cilium. It is still possible to force its execution by using the new env. variable MAKECLEAN. Avoiding the 'make clean' saves about 3m2s on a 5-minutes provisioning when Kubernetes & co. are already installed (including boot time). Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/vagrant-provisioning-improvements
branch
from
f9d0cf7
to
cb109b3
Compare
|
test-me-please |
|
test-docs-please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a few adjustments to provisioning, mostly to speed it up and ease restarts after interruptions:
cfsslbinaries.make cleanfor Cilium.Details in commit messages.