bugtool: add mode to retrieve pprof traces #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
pending-review
release-note/minor
|
test-me-please |
tklauser
approved these changes
Mar 23, 2020
bugtool/cmd/root.go
Outdated
| ) | ||
|
|
||
| func init() { | ||
| BugtoolRootCmd.Flags().BoolVar(&archive, "archive", true, "Create archive when false skips deletion of the output directory") | ||
| BugtoolRootCmd.Flags().BoolVar(&getPProf, "get-pprof", false, "When set, only gets the pprof traces from the cilium-agent binary") | ||
| BugtoolRootCmd.Flags().IntVar(&pprofPort, "pprof-port", 6060, "Port for which pprof server is exposed") |
There was a problem hiding this comment.
Nit:
Suggested change
| BugtoolRootCmd.Flags().IntVar(&pprofPort, "pprof-port", 6060, "Port for which pprof server is exposed") | |
| BugtoolRootCmd.Flags().IntVar(&pprofPort, "pprof-port", 6060, "Port on which pprof server is exposed") |
|
test-me-please |
Signed-off-by: André Martins <andre@cilium.io>
Retrieving pprof traces on a live cluster is extremely useful. Unfortunately this requires curl, or any http client, to be installed. Enabling this in the bugtool will make the capture of such pprof traces effortless for the user. By simply executing the following command in the cilium pod, the user will have an archive with the pprof traces for 60 seconds. ``` $ kubectl exec -ti -n kube-system <cilium-pod> -- ./cilium-bugtool --get-pprof --pprof-trace-seconds 60 ARCHIVE at /tmp/cilium-bugtool-20200323-141313.342+0000-UTC-490106087.tar $ kubectl cp -n kube-system <cilium-pod>:/tmp/cilium-bugtool-20200323-141313.342+0000-UTC-490106087.tar ./ ``` Signed-off-by: André Martins <andre@cilium.io>
|
test-me-please |
tklauser
approved these changes
Mar 23, 2020
|
Not sure about the test failure, but it looks like a flake? https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18131/ |
|
test-me-please |
1 similar comment
|
test-me-please |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.8
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.8
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugtool: add mode to retrieve pprof traces
Retrieving pprof traces on a live cluster is extremely useful.
Unfortunately this requires curl, or any http client, to be installed.
Enabling this in the bugtool will make the capture of such pprof
traces effortless for the user. By simply executing the following
command in the cilium pod, the user will have an archive with the pprof
traces for 60 seconds.
Signed-off-by: André Martins andre@cilium.io