datapath: Do not log if svc is not found #10668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to log (via cilium_dbg) when a packet dst IP + port did not
match any service, e.g:
CPU 20: MARK 0xbc243a3b FROM 0 DEBUG: Master service lookup failed, addr.p2=0 addr.p3=0
This added a lot of noise to `cilium monitor -D` output, especially when
bpf_netdev.o was attached to a native device (e.g when BPF NodePort was
enabled), as any inbound packet does a service lookup.
This commit removes the logging when a svc is not found. The fact that
a svc is not found can be deduced from a missing lookup svc endpoint log
message.
Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
pending-review
sig/datapath
|
test-me-please |
borkmann
approved these changes
Mar 23, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to log (via cilium_dbg) when a packet dst IP + port did not
match any service, e.g:
This added a lot of noise to
cilium monitor -Doutput, especially whenbpf_netdev.o was attached to a native device (e.g when BPF NodePort was
enabled), as any inbound packet does a service lookup.
This commit removes the logging when a svc is not found. The fact that
a svc is not found can be deduced from a missing lookup svc endpoint log
message.