Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Remove unused code #10671

Merged
merged 2 commits into from Mar 23, 2020
Merged

bpf: Remove unused code #10671

merged 2 commits into from Mar 23, 2020

Conversation

pchaigno
Copy link
Member

The first commit removes the orig_dport field of struct ct_state, which seems unused. The second commit moves the lb{4,6}_extract_key() call inside the # if !defined(ENABLE_HOST_SERVICES_FULL) || defined(ENABLE_EXTERNAL_IP) section; the call is unnecessary if those conditions are not met.

@pchaigno pchaigno added wip release-note/misc This PR makes changes that have no direct user impact. labels Mar 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 23, 2020
Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/remove-unnecessary-code branch from 9427a05 to 00ce234 Compare March 23, 2020 17:50
@coveralls
Copy link

coveralls commented Mar 23, 2020

Coverage Status

Coverage decreased (-0.01%) to 45.585% when pulling 00ce234 on pr/pchaigno/remove-unnecessary-code into cf0f9de on master.

@pchaigno
Copy link
Member Author

test-me-please

@pchaigno pchaigno added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. pending-review and removed wip labels Mar 23, 2020
@pchaigno pchaigno marked this pull request as ready for review March 23, 2020 20:27
@pchaigno pchaigno requested a review from a team March 23, 2020 20:27
@borkmann borkmann merged commit aea00a0 into master Mar 23, 2020
1.8.0 automation moved this from In progress to Merged Mar 23, 2020
@borkmann borkmann deleted the pr/pchaigno/remove-unnecessary-code branch March 23, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants