Improve k8s client heartbeat capability #10673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
pending-review
sig/k8s
|
Please set the appropriate release note label. |
2 similar comments
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
aanm
added
the
release-note/misc
|
test-me-please |
tgraf
requested changes
Mar 24, 2020
aanm
force-pushed
the
pr/fix-cilium-heartbeat
branch
2 times, most recently
from
9e6bfed
to
1f25d44
Compare
aanm
removed
the
sig/k8s
|
test-me-please |
There's no point on doing a get on the kube-system namespace since we can also perform the same operation in the `/healthz` endpoint which is also available to check if kube-apiserver is available. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Making the heartbeat as a function will allow to write unit tests more easily. Signed-off-by: André Martins <andre@cilium.io>
If Cilium has interactions with k8s, Cilium does not need to perform heatbeats to the kube-apiserver. Unless those interactions result in an error for which we should perform a heartbeat to kube-apiserver to check if the connection is still alive. In case the response from kube-apiserver is an error Cilium should then close all connections with the kube-apiserver. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
|
test-me-please |
aanm
force-pushed
the
pr/fix-cilium-heartbeat
branch
from
ee938a9
to
ab48bf4
Compare
|
hit #10118 |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the heartbeat to be done on
/healthzinstead of doing a geton kube-system namespace which has higher overhead than
/heatlhz.If Cilium has interactions with k8s, Cilium does not need to
perform heatbeats to the kube-apiserver. Unless those interactions
result in an error for which we should perform a heartbeat to
kube-apiserver to check if the connection is still alive. In case the
response from kube-apiserver is an error Cilium should then close all
connections with the kube-apiserver.
Read per commit for more details
follow up of #10184