Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node ip script path #10685

Merged
merged 2 commits into from Mar 24, 2020
Merged

Fix node ip script path #10685

merged 2 commits into from Mar 24, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented Mar 24, 2020

This change will cause images to not be built during k8s vm provisioning

@nebril nebril requested a review from a team as a code owner March 24, 2020 12:46
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 24, 2020
@nebril
Copy link
Member Author

nebril commented Mar 24, 2020

test-me-please

@nebril nebril added pending-review release-note/ci This PR makes changes to the CI. labels Mar 24, 2020
@nebril
Copy link
Member Author

nebril commented Mar 24, 2020

test-me-please

@nebril
ci: Fix node ip script path
201f75b 
This change will cause images to not be built during k8s vm provisioning

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
ci: Don't push images to k8s1 registry
7782bfb 
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/fix-docker-build-provision branch from 4b31150 to 7782bfb Compare March 24, 2020 13:50
@nebril
Copy link
Member Author

nebril commented Mar 24, 2020

test-focus K8sDemos.*

@nebril
Copy link
Member Author

nebril commented Mar 24, 2020

test-me-please

@coveralls
Copy link

coveralls commented Mar 24, 2020 •
edited

Coverage Status

Coverage increased (+0.02%) to 45.551% when pulling 7782bfb on pr/fix-docker-build-provision into d512d92 on master.

@nebril
Copy link
Member Author

nebril commented Mar 24, 2020

test-focus K8sDemos.*

@nebril
Copy link
Member Author

nebril commented Mar 24, 2020

test-me-please

@borkmann borkmann merged commit 5346170 into master Mar 24, 2020
1.8.0 automation moved this from In progress to Merged Mar 24, 2020
@borkmann borkmann deleted the pr/fix-docker-build-provision branch March 24, 2020 20:18
@nebril nebril mentioned this pull request Apr 14, 2020
Merged
@joestringer joestringer added this to Backport done to v1.7 in 1.7.3 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raybejjani raybejjani raybejjani approved these changes

Assignees
No one assigned
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.7.3
Backport done to v1.7
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nebril @coveralls @raybejjani @borkmann @joestringer