Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: Change AWS policy group provider registration #10689

Merged
merged 1 commit into from Mar 24, 2020
Merged

operator: Change AWS policy group provider registration #10689

merged 1 commit into from Mar 24, 2020

Conversation

errordeveloper
Copy link
Contributor

This is a simple change towards #9920.

@errordeveloper
operator: Change AWS policy group provider registration
9f45458 
- Move AWS policy groups provider registration into operator,
  as it's not used anywhere else
- Add `operator_aws` build tag to exclude this dependency in
  non-AWS builds (see #9920)

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper errordeveloper added kind/cleanup This includes no functional changes. area/operator Impacts the cilium-operator component release-note/misc This PR makes changes that have no direct user impact. labels Mar 24, 2020
@errordeveloper errordeveloper requested a review from a team as a code owner March 24, 2020 17:34
@errordeveloper errordeveloper requested a review from a team March 24, 2020 17:34
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 24, 2020
christarazi
christarazi approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 45.631% when pulling 9f45458 on pr/errordeveloper/operator-aws-tag into d03d08e on master.

@errordeveloper
Copy link
Contributor Author

test-me-please

@tgraf tgraf merged commit 6290f20 into master Mar 24, 2020
1.8.0 automation moved this from In progress to Merged Mar 24, 2020
@tgraf tgraf deleted the pr/errordeveloper/operator-aws-tag branch March 24, 2020 21:21
@tklauser tklauser mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/operator Impacts the cilium-operator component kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@errordeveloper @coveralls @christarazi @tgraf