Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Minor adjustments to the development dependencies #10697

Merged
merged 2 commits into from Mar 25, 2020
Merged

docs: Minor adjustments to the development dependencies #10697

merged 2 commits into from Mar 25, 2020

Conversation

pchaigno
Copy link
Member

First commit reworks documentation dependencies, second clarifies need to use docker as non-root user for unit tests.

@pchaigno pchaigno added pending-review area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 25, 2020
@pchaigno pchaigno requested a review from a team as a code owner March 25, 2020 12:22
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 25, 2020
@pchaigno pchaigno changed the title Minor adjustments to the development dependencies docs: Minor adjustments to the development dependencies Mar 25, 2020
@coveralls
Copy link

coveralls commented Mar 25, 2020 •
edited

Coverage Status

Coverage increased (+0.003%) to 45.443% when pulling 4d2ef68 on pr/pchaigno/fixes-for-dependencies into 2c45e80 on master.

@pchaigno
docs: Update requirements for documentation
91bd714 
pip is needed to install the documentation dependencies. Those
dependencies are not limited to sphinx and can be installed from the
Documentation/requirements.txt file.

I've moved the documentation dependencies closer to the default
dependencies because, contrary to Vagrant and VirtualBox, they are
needed to run make.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
docs: Clarify need to run docker as non-root user
4d2ef68 
docker must be executed as a non-root user for unit tests.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/fixes-for-dependencies branch from 8aff620 to 4d2ef68 Compare March 25, 2020 16:03
@pchaigno
Copy link
Member Author

test-docs-please

@borkmann borkmann merged commit 4642a1d into master Mar 25, 2020
1.8.0 automation moved this from In progress to Merged Mar 25, 2020
@borkmann borkmann deleted the pr/pchaigno/fixes-for-dependencies branch March 25, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pchaigno @coveralls @tklauser @borkmann