Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker, runtime: remove apt cache from runtime image #10704

Merged
merged 1 commit into from Mar 26, 2020
Merged

docker, runtime: remove apt cache from runtime image #10704

merged 1 commit into from Mar 26, 2020

Conversation

tklauser
Copy link
Member

Do as suggested in the Dockerfile best practices [1]. This further
reduces the footprint of the cilium-runtime image by ~26MB.

[1] https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run

@tklauser tklauser added pending-review kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Mar 25, 2020
@tklauser tklauser requested a review from borkmann March 25, 2020 17:15
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 25, 2020
@tklauser
Copy link
Member Author

test-me-please

@tklauser tklauser force-pushed the pr/tklauser/docker-runtime-remove-apt-cache branch from 92bf092 to d2ac1ee Compare March 25, 2020 17:22
@tklauser tklauser requested a review from a team as a code owner March 25, 2020 17:22
pchaigno
pchaigno approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tklauser
docker, runtime: remove apt cache from runtime image
abec387 
Do as suggested in the Dockerfile best practices [1].  This further
reduces the footprint of the cilium-runtime image by ~26MB.

[1] https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/docker-runtime-remove-apt-cache branch from d2ac1ee to abec387 Compare March 25, 2020 17:25
@tklauser tklauser changed the title docker, runtime: remove apt cache in runtime image docker, runtime: remove apt cache from runtime image Mar 25, 2020
christarazi
christarazi approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 45.414% when pulling abec387 on pr/tklauser/docker-runtime-remove-apt-cache into 00bba82 on master.

@christarazi
Copy link
Member

test-me-please

@tklauser
Copy link
Member Author

Testing this needs to wait for the cilium-runtime image build on quay to finish.

@borkmann
Copy link
Member

test-me-please

@borkmann borkmann merged commit 7c023b5 into master Mar 26, 2020
1.8.0 automation moved this from In progress to Merged Mar 26, 2020
@borkmann borkmann deleted the pr/tklauser/docker-runtime-remove-apt-cache branch March 26, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@pchaigno pchaigno pchaigno approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm Awaiting requested review from aanm

@ianvernon ianvernon Awaiting requested review from ianvernon

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @coveralls @christarazi @borkmann @pchaigno