New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib: Add script to bump stable releases #10711
contrib: Add script to bump stable releases #10711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually like to add set -euo pipefail
for bash scripts. It would be great if we can add this to the docs as well. Otherwise, nice!
Ah, good point, I was assuming that these are set in the included common/lib scripts and that those settings would propagate out to this script, which I think is true but worth double-checking. Agree on the docs, question will be whether we move towards retiring the docs for generating releases and roll this into the github issue template for releases. Or for that matter if we just avoid using this script manually and script up a github action to invoke it automatically.. |
I quickly glanced at the "usage" section of the script and thought that could go in the docs. But it seems simple enough after a second look, so probably not worth doing. Eventually a GitHub action is probably the most fitting for this kind of thing. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christarazi @joestringer is this good to be merged besides my nits?
@aanm Good to go for me. |
Add a script to create a new commit bumping the README and github actions for newly released versions. Usage: $ git fetch origin $ git checkout -b pr/bump-readme-$(date --rfc-3339=date) origin/master $ ./contrib/release/bump-readme $ git push <open PR> Signed-off-by: Joe Stringer <joe@cilium.io>
0323269
to
bd785d0
Compare
Moved, and updated the issue template for releases. |
Add a script to create a new commit bumping the README and github
actions for newly released versions.
Usage:
Used to create #10710.