Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: Add script to bump stable releases #10711

Merged
merged 1 commit into from Apr 1, 2020

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Mar 25, 2020

Add a script to create a new commit bumping the README and github
actions for newly released versions.

Usage:

$ git fetch origin
$ git checkout -b pr/bump-readme-$(date --rfc-3339=date) origin/master
$ ./contrib/release/bump-readme
$ git push
<open PR>

Used to create #10710.

@joestringer joestringer added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Mar 25, 2020
@joestringer joestringer requested a review from a team as a code owner March 25, 2020 23:42
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 25, 2020
@coveralls
Copy link

coveralls commented Mar 26, 2020

Coverage Status

Coverage increased (+0.002%) to 45.512% when pulling bd785d0 on joestringer:submit/bump-release-script into c08e72a on cilium:master.

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually like to add set -euo pipefail for bash scripts. It would be great if we can add this to the docs as well. Otherwise, nice!

@joestringer
Copy link
Member Author

Ah, good point, I was assuming that these are set in the included common/lib scripts and that those settings would propagate out to this script, which I think is true but worth double-checking.

Agree on the docs, question will be whether we move towards retiring the docs for generating releases and roll this into the github issue template for releases.

Or for that matter if we just avoid using this script manually and script up a github action to invoke it automatically..

@christarazi
Copy link
Member

I quickly glanced at the "usage" section of the script and thought that could go in the docs. But it seems simple enough after a second look, so probably not worth doing. Eventually a GitHub action is probably the most fitting for this kind of thing. 👍

Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christarazi @joestringer is this good to be merged besides my nits?

contrib/release/bump-readme Outdated Show resolved Hide resolved
@christarazi
Copy link
Member

@aanm Good to go for me.

Add a script to create a new commit bumping the README and github
actions for newly released versions.

Usage:

$ git fetch origin
$ git checkout -b pr/bump-readme-$(date --rfc-3339=date) origin/master
$ ./contrib/release/bump-readme
$ git push
<open PR>

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Copy link
Member Author

Moved, and updated the issue template for releases.

@joestringer joestringer merged commit 19b5b7c into cilium:master Apr 1, 2020
1.8.0 automation moved this from In progress to Merged Apr 1, 2020
@joestringer joestringer deleted the submit/bump-release-script branch April 1, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants