Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules, mountinfo: check scanner.Err after scanner.Scan #10720

Merged
merged 1 commit into from Mar 27, 2020
Merged

modules, mountinfo: check scanner.Err after scanner.Scan #10720

merged 1 commit into from Mar 27, 2020

Conversation

tklauser
Copy link
Member

Check for any non-EOF errors after scanner.Scan.

@tklauser tklauser added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Mar 26, 2020
@tklauser tklauser requested review from vadorovsky and a team March 26, 2020 15:30
@tklauser tklauser requested a review from a team as a code owner March 26, 2020 15:30
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 26, 2020
@tklauser
Copy link
Member Author

tklauser commented Mar 26, 2020 •
edited by christarazi

test-me-please

Edit: Kafka flake: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18256/#showFailuresLink

@coveralls
Copy link

coveralls commented Mar 26, 2020 •
edited

Coverage Status

Coverage increased (+0.04%) to 45.546% when pulling a457b0c on pr/tklauser/scanner-err into 5ff7c51 on master.

@christarazi
Copy link
Member

test-me-please

@tklauser
modules, mountinfo: check scanner.Err after scanner.Scan
a457b0c 
Check for any non-EOF errors after `scanner.Scan`.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
Copy link
Member Author

test-me-please

@borkmann borkmann merged commit 47b9b06 into master Mar 27, 2020
1.8.0 automation moved this from In progress to Merged Mar 27, 2020
@borkmann borkmann deleted the pr/tklauser/scanner-err branch March 27, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@christarazi christarazi christarazi approved these changes

@vadorovsky vadorovsky Awaiting requested review from vadorovsky

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @coveralls @christarazi @brb @borkmann