Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Quieten cmdref generation #10725

Merged
merged 1 commit into from Mar 26, 2020

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Mar 26, 2020

The cmdref generation target had the verbose flag which ignored the
developer's request for $QUIET. Remove that flag.

Manually validated; I assume also the Github action for docs build will validate.

@joestringer joestringer added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Mar 26, 2020
@joestringer joestringer requested a review from a team as a code owner March 26, 2020 18:46
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 26, 2020
The cmdref generation target had the verbose flag which ignored the
developer's request for $QUIET. Remove that flag.

While we're at it, fix a whitespace issue in printing the check.

Signed-off-by: Joe Stringer <joe@cilium.io>
Copy link
Contributor

@soumynathan soumynathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link

coveralls commented Mar 26, 2020

Coverage Status

Coverage decreased (-0.03%) to 45.508% when pulling 28273f2 on joestringer:submit/fix-quiet-build into 7067dcb on cilium:master.

@christarazi christarazi merged commit 5ff7c51 into cilium:master Mar 26, 2020
1.8.0 automation moved this from In progress to Merged Mar 26, 2020
@joestringer joestringer deleted the submit/fix-quiet-build branch March 26, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants