Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add bash aliases and completion for kubectl #10726

Merged
merged 1 commit into from Mar 27, 2020
Merged

test: Add bash aliases and completion for kubectl #10726

merged 1 commit into from Mar 27, 2020

Conversation

brb
Copy link
Member

@brb brb commented Mar 26, 2020

This commit adds the following to the test VMs:

  • Alias k for kubectl
  • Alias ks for kubectl -n kube-system
  • Shell function cilium_pod $NODE_NAME for getting cilium-agent pod name
  • Bash completion for kubectl

@brb
test: Add bash aliases and completion for kubectl
cddc040 
This commit adds the following to the test VMs:

* Alias k for kubectl
* Alias ks for kubectl -n kube-system
* Shell function cilium_pod $NODE_NAME for getting cilium-agent pod name
* Bash completion for kubectl

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added pending-review area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/misc This PR makes changes that have no direct user impact. labels Mar 26, 2020
@brb brb requested a review from a team as a code owner March 26, 2020 20:35
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 26, 2020
@brb
Copy link
Member Author

brb commented Mar 26, 2020

test-me-please

@coveralls
Copy link

coveralls commented Mar 26, 2020 •
edited

Coverage Status

Coverage decreased (-0.04%) to 45.506% when pulling cddc040 on pr/brb/kubectl-completion into 7067dcb on master.

@brb
Copy link
Member Author

brb commented Mar 27, 2020

CI hit the recent Kafka flakes. Re-running.

@brb
Copy link
Member Author

brb commented Mar 27, 2020

test-me-please

pchaigno
pchaigno approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have the same for the dev. VM?

@pchaigno
Copy link
Member

test-me-please

@borkmann borkmann merged commit 53cf46a into master Mar 27, 2020
1.8.0 automation moved this from In progress to Merged Mar 27, 2020
@borkmann borkmann deleted the pr/brb/kubectl-completion branch March 27, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brb @coveralls @pchaigno @borkmann