make: pick up all privileged tests in make tests-privileged
#10734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
pending-review
release-note/misc
tklauser
force-pushed
the
pr/tklauser/run-all-privileged-tests
branch
from
a81cf0f
to
7c866ae
Compare
|
test-me-please |
|
Cherry-picked @christarazi's fix from #10729 to be able to run tests (commit fe4bbd5e3430f3768190c63870ae3e8e538c0d9f in this PR). |
This seems like an innocent mistake during #8954. #8954 (comment) Signed-off-by: Chris Tarazi <chris@isovalent.com>
As seen in #10729 some privileged tests currently aren't picked up by the `tests-privileged` rule because it expects the `privileged_tests` build tag to directly follow `+build`. However, some `*_test.go` files use additional build tags before that. Account for that when evaluating the privileged tests to run. At current `HEAD` this will pick up 3 more privileged test packages: ``` % grep --include='*.go' -ril '+build privileged_tests' . | wc -l 16 % grep --include='*.go' -ril '+build [^!]*privileged_tests' . | wc -l 19 ``` Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Fix the follow test build errors: ``` # github.com/cilium/cilium/pkg/sysctl [github.com/cilium/cilium/pkg/sysctl.test] pkg/sysctl/sysctl_linux_privileged_test.go:43:4: cannot use "1" (type string) as type []byte in field value pkg/sysctl/sysctl_linux_privileged_test.go:48:4: cannot use "1" (type string) as type []byte in field value pkg/sysctl/sysctl_linux_privileged_test.go:53:4: cannot use "1" (type string) as type []byte in field value pkg/sysctl/sysctl_linux_privileged_test.go:58:4: cannot use "1" (type string) as type []byte in field value pkg/sysctl/sysctl_linux_privileged_test.go:64:33: cannot use tc.value (type []byte) as type string in argument to writeSysctl ``` Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/run-all-privileged-tests
branch
from
7c866ae
to
ebd4b18
Compare
|
test-me-please |
christarazi
approved these changes
Mar 27, 2020
pchaigno
approved these changes
Mar 27, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #10729 some privileged tests currently aren't picked up by
the
tests-privilegedrule because it expects theprivileged_testsbuild tag to directly follow
+build. However, some*_test.gofilesuse additional build tags before that. Account for that when evaluating
the privileged tests to run. At current
HEADthis will pick up 3 moreprivileged test packages:
To be merged after #10729
/cc @joestringer @christarazi