Fix bpf unit test build in dev VM #10735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent changes in #10703 the dev VM no longer ships a general purpose `clang` with all targets, but only one with the `bpf` target. This leads to the build in `test/bpf` to fail: ``` clang -I../../bpf/ -I../../bpf/include -I. -D__NR_CPUS__=2 -O2 -I../../bpf/ unit-test.c -o unit-test error: unable to create target: 'No available targets are compatible with triple "x86_64-unknown-linux-gnu"' ``` To fix this, use `gcc` to build non-bpf binaries. Suggested-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Fix the following warning:
```
gcc -I../../bpf/ -I../../bpf/include -I. -D__NR_CPUS__=2 -O2 -I../../bpf/ unit-test.c -o unit-test
In file included from unit-test.c:20:0:
../../bpf/lib/conntrack_test.h: In function ‘test___ct_lookup’:
../../bpf/lib/conntrack_test.h:88:31: warning: dereferencing ‘void *’ pointer
struct ct_entry *entry = &map[0];
^
```
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
pending-review
release-note/misc
|
test-me-please |
pchaigno
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes in #10703 the dev VM no longer ships a general
purpose
clangwith all targets, but only one with thebpftarget.This leads to the build in
test/bpfto fail:To fix this, use
gccto build non-bpf binaries. Also fix a GCC warning inbpf/lib/conntrack_test.h.