Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: preallocate prefilter spec slices with known size #10751

Merged
merged 1 commit into from Mar 31, 2020
Merged

daemon: preallocate prefilter spec slices with known size #10751

merged 1 commit into from Mar 31, 2020

Conversation

tklauser
Copy link
Member

These were missed in #10716

@tklauser
daemon: preallocate prefilter spec slices with known size
446faab 
These were missed in #10716

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Mar 30, 2020
@tklauser tklauser requested a review from a team March 30, 2020 08:28
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 30, 2020
@tklauser
Copy link
Member Author

tklauser commented Mar 30, 2020 •
edited

test-me-please

EDIT: hit #9282 https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18320/

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 45.531% when pulling 446faab on pr/tklauser/daemon-prealloc into 3a49c6c on master.

@tklauser
Copy link
Member Author

test-me-please

@errordeveloper
Copy link
Contributor

@tklauser ok to remove pending-review and megre?

@tklauser
Copy link
Member Author

@errordeveloper yes, though I cannot merge myself.

@tklauser tklauser added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed pending-review labels Mar 31, 2020
@errordeveloper
Copy link
Contributor

@tklauser me neither...

@errordeveloper errordeveloper merged commit 742456c into master Mar 31, 2020
1.8.0 automation moved this from In progress to Merged Mar 31, 2020
@errordeveloper errordeveloper deleted the pr/tklauser/daemon-prealloc branch March 31, 2020 14:49
@tklauser tklauser mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @coveralls @errordeveloper @aanm @qmonnet