Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-flight: Correct tofqdns-precache container name #10753

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

raybejjani
Copy link
Contributor

@raybejjani raybejjani commented Mar 30, 2020

We accidentally duplicated the container name when we separated the init
container into two. We don't refer to this anywhere directly so any
other name should be fine.

fixes 52a12df
fixes #10745

We accidentally duplicated the container name when we separated the init
container into two. We don't refer to this anywhere directly so any
other name should be fine.

fixes 52a12df

Signed-off-by: Ray Bejjani <ray@isovalent.com>
@raybejjani raybejjani added kind/bug This is a bug in the Cilium logic. pending-review release-note/bug This PR fixes an issue in a previous release of Cilium. labels Mar 30, 2020
@raybejjani raybejjani requested a review from a team March 30, 2020 09:47
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 30, 2020
@raybejjani
Copy link
Contributor Author

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.2 Mar 30, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 45.5% when pulling 55de63a on raybejjani:preflight-fix-double-container into ba0fd4c on cilium:master.

@aanm aanm merged commit d982492 into cilium:master Mar 30, 2020
1.8.0 automation moved this from In progress to Merged Mar 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.2 Mar 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.2 Mar 30, 2020
@raybejjani raybejjani deleted the preflight-fix-double-container branch March 30, 2020 14:42
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.2 Apr 1, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.2 Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.7.2
Backport done to v1.7
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

cilium preflight fqdn-poller pre-flight check has duplicate container name
4 participants