k8s: Defer marking node as ready to just API is served #10767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kubernetes node was marked as ready after the daemon was finished initializing. There were still several operations that could fail after that point which could lead to a situation in which a node was marked ready while the Cilium agent then later errored out, leading to a ready but failing node. Move the marking of the node readiness to the very end of the bootstrapping. Fixes: #10762 Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
pending-review
release-note/bug
|
test-me-please All tests passed except for known flake:
|
|
test-me-please CI was hitting #10760 (specifically |
aanm
approved these changes
Mar 31, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes node was marked as ready after the daemon was finished
initializing. There were still several operations that could fail after
that point which could lead to a situation in which a node was marked
ready while the Cilium agent then later errored out, leading to a ready
but failing node.
Move the marking of the node readiness to the very end of the
bootstrapping.
Fixes: #10762