bpf: Fix name for example map #10768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
pending-review
kind/cleanup
|
test-focus RuntimeVerifier |
pchaigno
approved these changes
Mar 31, 2020
tklauser
approved these changes
Mar 31, 2020
These map names were the same as the ones in Cilium, which is explicitly what we *don't* want, as that can cause local testing to interfere with real Cilium agent instances. This was picked up by running Cilium then running test/bpf/verifier-test.sh This was picked up by running Cilium then running test/bpf/verifier-test.sh, which fails due to the maps already existing on the filesystem. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/fix-verifier-test-map-name
branch
from
0f552b8
to
787e7f7
Compare
|
test-me-please |
1 similar comment
|
test-me-please |
|
Tests with kernel passed which shows the changes are good. Regular Ginkgo run seems to be flaking on known policy issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These map names were the same as the ones in Cilium, which is explicitly
what we don't want, as that can cause local testing to interfere with
real Cilium agent instances. This was picked up by running Cilium then
running test/bpf/verifier-test.sh This was picked up by running Cilium
then running test/bpf/verifier-test.sh, which fails due to the maps
already existing on the filesystem.