pkg/allocator: do not fail to allocate identity in CRD mode #10785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case 2 allocations with the same key are being allocated at the same time one of them might retrieve the ID while the other will try to allocate the ID in the CRD store. The issue occurs when the localKeys map will ignore the 2nd key allocation since it won't accept 2 IDs for the same key. Having this failure might cause endpoints from being restored in CRD mode. Signed-off-by: André Martins <andre@cilium.io>
aanm
added
pending-review
priority/high
|
Please set the appropriate release note label. |
4 similar comments
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
aanm
added
the
release-note/bug
|
test-me-please |
jrajahalme
approved these changes
Mar 31, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case 2 allocations with the same key are being allocated at the
same time one of them might retrieve the ID while the other will
try to allocate the ID in the CRD store. The issue occurs when the
localKeys map will ignore the 2nd key allocation since it won't accept 2
IDs for the same key. Having this failure might cause endpoints from
being restored in CRD mode.
Signed-off-by: André Martins andre@cilium.io
Fix #10774