pkg/k8s: fix heartbeat unit test #10790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unit test logic for the heartbeat function mock. In some test cases this function should block until the test is finished so some of those tests were re-written to take this into account. Signed-off-by: André Martins <andre@cilium.io>
|
test-me-please |
|
restart-ginkgo |
|
restart-ginkgo |
joestringer
approved these changes
Apr 1, 2020
|
This is a unit test change which passes Travis and also passes one of the ginkgo runs, so I'm overriding the failed check for flakes on the other ginkgo runs. (I reviewed too, LGTM) |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unit test logic for the heartbeat function mock. In some test cases
this function should block until the test is finished so some of those
tests were re-written to take this into account.
Signed-off-by: André Martins andre@cilium.io
Fixes: #10770
3rd time's a charm...
I've ran this test locally 100 times and I didn't hit any failures with the new changes.