Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Cilium with CRIO on minikube #10796

Merged

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Mar 31, 2020

This updates the "Getting Started" docs for minikube. This commit was
added to address issue #10624


I was able to reproduce the issue very easily. I think it would be helpful to have a small note about it because it is not obvious at all what could be going wrong, even though "Getting Started" docs are supposed to be concise.

Fixes #10624

This updates the "Getting Started" docs for minikube. This commit was
added to address issue cilium#10624.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 31, 2020
@christarazi christarazi requested a review from a team as a code owner March 31, 2020 23:47
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 31, 2020
@christarazi
Copy link
Member Author

test-docs-please

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple, minimal suggestion that should help address problems users have faced with the minikube guide. LGTM.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 45.468% when pulling 893a5a0 on christarazi:pr/christarazi/update-minikube-crio-docs into 912eb46 on cilium:master.

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 1, 2020
@aanm aanm merged commit 5d679fb into cilium:master Apr 1, 2020
1.8.0 automation moved this from In progress to Merged Apr 1, 2020
@christarazi christarazi deleted the pr/christarazi/update-minikube-crio-docs branch April 1, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

After installing cilium 1.7.1 on minikube + cri-o, coredns never stops respawning
5 participants