Split out cleanups from #10806 #10823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
pending-review
release-note/misc
|
test-me-please |
|
test-with-kernel |
|
restart-ginkgo |
Closed
The large list of files unnecessarily clutters the log. Just print the name of the check. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Get rid of some superflous horizontal spacing in the rst source. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
aanm
reviewed
Apr 2, 2020
Dockerfile.builder
Outdated
| cd /go/src/github.com/gordonklaus/ineffassign && \ | ||
| git checkout -b 1003c8bd00dc2869cb5ca5282e6ce33834fed514 1003c8bd00dc2869cb5ca5282e6ce33834fed514 && \ | ||
| go install | ||
| GO111MODULE=on go get github.com/gordonklaus/ineffassign@1003c8bd00dc2869cb5ca5282e6ce33834fed514 |
There was a problem hiding this comment.
we might need to update the docker image tags in this PR
There was a problem hiding this comment.
Good point. I only updated it for #10806 (cilium-builder:2020-04-01).
There was a problem hiding this comment.
Image is currently building and I updated the tag in Dockerfile to cilium-builder:2020-04-02. While at it I also noticed that we can reduce the image size a bit by running go clean -cache -modcache after go install to get rid of the build and module download caches.
…ssign Also clean the Go build and module download caches to reduce the container image size. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/prealloc-split-out
branch
from
940f2e1
to
ab4ffca
Compare
|
restart-ginkgo |
|
test-with-kernel |
|
test-docs-please |
joestringer
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup commits split out of #10806
See individual commit messages.