Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/bpf: remove unused metrics labels #10830

Merged
merged 1 commit into from Apr 2, 2020
Merged

pkg/bpf: remove unused metrics labels #10830

merged 1 commit into from Apr 2, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 2, 2020

These are unused since commits 48327b9 ("bpf: remove unused
GetProgNextID and GetProgFDByID") and ae53f9c ("bpf: Delete perf
event reader implementation"), respectively.

@tklauser
pkg/bpf: remove unused metrics labels
653bd8f 
These are unused since commits 48327b9 ("bpf: remove unused
GetProgNextID and GetProgFDByID") and ae53f9c ("bpf: Delete perf
event reader implementation"), respectively.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Apr 2, 2020
@tklauser tklauser requested review from joestringer and a team April 2, 2020 15:23
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 2, 2020
@tklauser
Copy link
Member Author

tklauser commented Apr 2, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 45.474% when pulling 653bd8f on pr/tklauser/pkg-bpf-remove-metrics-labels into 8162f6b on master.

joestringer
joestringer approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch.

@joestringer
Copy link
Member

Cilium-Tests-With-Kernel hit #10821 on a different test, K8sDatapathConfig Encapsulation Check connectivity with VXLAN encapsulation. Will override.

@joestringer joestringer merged commit b9d2105 into master Apr 2, 2020
1.8.0 automation moved this from In progress to Merged Apr 2, 2020
@joestringer joestringer deleted the pr/tklauser/pkg-bpf-remove-metrics-labels branch April 2, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tklauser @coveralls @joestringer @aanm