Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/runtime: remove unused runtimeConnectivityTest #10835

Merged
merged 1 commit into from Apr 3, 2020
Merged

test/runtime: remove unused runtimeConnectivityTest #10835

merged 1 commit into from Apr 3, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 2, 2020

It's unused since commit 7fe5304 ("test: Remove runtime ipvlan
tests") via PR #10145.

@tklauser
test/runtime: remove unused runtimeConnectivityTest
62d7f6f 
It's unused since commit 7fe5304 ("test: Remove runtime ipvlan
tests") via PR #10145.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review kind/cleanup This includes no functional changes. labels Apr 2, 2020
@tklauser tklauser requested a review from brb April 2, 2020 16:44
@tklauser tklauser requested a review from a team as a code owner April 2, 2020 16:44
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

2 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 2, 2020
@tklauser
Copy link
Member Author

tklauser commented Apr 2, 2020

test-me-please

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Apr 2, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 45.464% when pulling 62d7f6f on pr/tklauser/remove-unused-runtime-connectivity-test into 8162f6b on master.

@tklauser
Copy link
Member Author

tklauser commented Apr 2, 2020

test-with-kernel

@ciliumbot
Copy link

Build finished.

@tklauser
Copy link
Member Author

tklauser commented Apr 3, 2020

test-with-kernel

@errordeveloper
Copy link
Contributor

@tklauser is this one ready to merge yet?

@tklauser tklauser added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed pending-review labels Apr 3, 2020
@tklauser
Copy link
Member Author

tklauser commented Apr 3, 2020

@errordeveloper Yes, sorry forgot to check the build status and mark as ready-to-merge.

@joestringer joestringer merged commit 0c66743 into master Apr 3, 2020
1.8.0 automation moved this from In progress to Merged Apr 3, 2020
@joestringer joestringer deleted the pr/tklauser/remove-unused-runtime-connectivity-test branch April 3, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tklauser @coveralls @ciliumbot @errordeveloper @brb @joestringer