Adds newline after unit-tests target.

[Weil0ng]

It seems that in some env if the path is large enough for the full list
of files, the full bash command in that target gets too big for bash and
hence will trigger an error too many arguments. (figured out by
@aanm and @joestringer )

Fixes: #10836

Signed-off-by: Weilong Cui cuiwl@google.com

[maintainer-s-little-helper]

Please set the appropriate release note label.

[Weil0ng]

@joestringer @aanm

[joestringer]

Couple of minor nits.

[joestringer]

@Weil0ng for this issue since it fixes #10836, if you write "Fixes: #10836" in the PR or commit message then github will autoclose the other issue when this is merged.

[coveralls]

Coverage decreased (-0.01%) to 45.888% when pulling 3b51a86 on Weil0ng:newline into e774b9c on cilium:master.

[Weil0ng]

PTAL

[joestringer]

test-me-please

[pchaigno]

I think the Travis CI failure is related:

go test -mod=vendor -ldflags "-X github.com/cilium/cilium/pkg/kvstore.consulDummyConfigFile=/tmp/cilium-consul-certs/cilium-consul.yaml -X github.com/cilium/cilium/pkg/testutils.CiliumRootDir=/home/travis/gopath/src/github.com/cilium/cilium -X github.com/cilium/cilium/pkg/datapath.DatapathSHA=1234567890abcdef7890 -X github.com/cilium/cilium/pkg/logging.DefaultLogLevelStr="error"" github.com/cilium/cilium/bugtool -test.v -timeout 360s -coverprofile=coverage.out -covermode=count -coverpkg ./... || exit 1; tail -n +2 coverage.out >> coverage-all-tmp.out;
/bin/bash: 2: unbound variable
Makefile:152: recipe for target 'unit-tests' failed
make: *** [unit-tests] Error 1
The command "./.travis/build.sh" exited with 2.

It was also failing with the same error on the previous build, for aarch64 only as well.

[aanm]

@Weil0ng it seems is a legit failure in travis:

go test -mod=vendor -ldflags "-X github.com/cilium/cilium/pkg/kvstore.consulDummyConfigFile=/tmp/cilium-consul-certs/cilium-consul.yaml -X github.com/cilium/cilium/pkg/testutils.CiliumRootDir=/home/travis/gopath/src/github.com/cilium/cilium -X github.com/cilium/cilium/pkg/datapath.DatapathSHA=1234567890abcdef7890 -X github.com/cilium/cilium/pkg/logging.DefaultLogLevelStr="error"" github.com/cilium/cilium/bugtool -test.v -timeout 360s -coverprofile=coverage.out -covermode=count -coverpkg ./... || exit 1; tail -n +2 coverage.out >> coverage-all-tmp.out;
/bin/bash: 2: unbound variable
Makefile:152: recipe for target 'unit-tests' failed
make: *** [unit-tests] Error 1

[Weil0ng]

PTAL. Have to use another workaround to cope with different versions of bash.

[joestringer]

Travis still seems unhappy, so I'll defer review until it is green.

[joestringer]

LGTM

[joestringer]

test-me-please

[Weil0ng]

hmm, that's odd, the failure seems like unrelated to this PR...

[joestringer]

@Weil0ng It may be. Usually we will try to look for issues with the test name and reference the issue so that we can track common flakes on master and make progress towards resolving them.

[pchaigno]

Previous run hit #10821.

test-with-kernel