Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: Remove old policy call map #10845

Merged
merged 1 commit into from Apr 6, 2020
Merged

daemon: Remove old policy call map #10845

merged 1 commit into from Apr 6, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Apr 3, 2020

The policy call map was renamed in commit 5d6b669 from cilium_policy to cilium_call_policy, but the code to remove the old reference in case of upgrade is missing.

Related: #10626
Fixes: #10781.

@pchaigno
daemon: Remove old policy call map
b199333 
The policy call map was renamed in commit 5d6b669 from cilium_policy to
cilium_call_policy, but the code to remove the old reference in case of
upgrade is missing.

Fixes: 5d6b669 ("maps/policymap: Rename policy call map to clarify intent")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/daemon Impacts operation of the Cilium daemon. release-note/misc This PR makes changes that have no direct user impact. labels Apr 3, 2020
@pchaigno pchaigno requested a review from a team April 3, 2020 13:14
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 3, 2020
@pchaigno
Copy link
Member Author

pchaigno commented Apr 3, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 45.947% when pulling b199333 on pr/pchaigno/remove-old-policy-callmap into 268446b on master.

@pchaigno
Copy link
Member Author

pchaigno commented Apr 5, 2020

test-with-kernel

@tgraf tgraf merged commit 6bada02 into master Apr 6, 2020
1.8.0 automation moved this from In progress to Merged Apr 6, 2020
@tgraf tgraf deleted the pr/pchaigno/remove-old-policy-callmap branch April 6, 2020 15:52
This was referenced Sep 2, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup old policy call map
5 participants
@pchaigno @coveralls @tklauser @joestringer @tgraf