-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs policy title rename #10854
Docs policy title rename #10854
Conversation
Please set the appropriate release note label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit on title change looks good, but it looks like the other commit was added to this PR by mistake? I think this is the commit already submitted in #10853.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dan Wendlandt <dan@covalent.io>
d8f4f62
to
64b7fbf
Compare
@qmonnet , ah good catch. Sorry about that! I've cleaned up and re-pushed. |
We do not have a separate policy tutorial that covers basic identity-aware network policy, but the title of the star wars demo just talks about HTTP, despite the fact that it covers both label-based identity policies as well as HTTP-aware policies. Just make the title reflect this.