Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Clarify help of 'cilium map' #10855

Merged
merged 1 commit into from Apr 6, 2020
Merged

cli: Clarify help of 'cilium map' #10855

merged 1 commit into from Apr 6, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Apr 6, 2020

This commit clarifies that cilium map get [name] returns a userspace cache of the map content and not the actual map content.

@pchaigno
cli: Clarify help of 'cilium map'
d54a0d4 
This commit clarifies that 'cilium map get name' returns a userspace
cache of the map content and not the actual map content.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/cli Impacts the command line interface of any command in the repository. labels Apr 6, 2020
@pchaigno pchaigno requested review from a team as code owners April 6, 2020 06:48
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 6, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 45.882% when pulling d54a0d4 on pr/pchaigno/clarify-map-list-help into c3dee35 on master.

@joestringer joestringer merged commit 4d0e2ef into master Apr 6, 2020
1.8.0 automation moved this from In progress to Merged Apr 6, 2020
@joestringer joestringer deleted the pr/pchaigno/clarify-map-list-help branch April 6, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @coveralls @brb @qmonnet @joestringer