CI: K8sFQDNTest retry initial DNS lookups #10871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raybejjani
added
pending-review
area/CI
|
test-focus K8sFQDNTest.* |
|
test-gke K8sFQDNTest.* |
nebril
requested changes
Apr 7, 2020
test/k8sT/fqdn.go
Outdated
| worldInvalidTargetIP = addrs[0] | ||
|
|
||
| return true | ||
| }, "Could not get vagrant-cache.ci.cilium.io and jenkins.cilium.io IPs", &helpers.TimeoutConfig{Timeout: 30 * time.Second}) |
There was a problem hiding this comment.
Can we use helpers.MidCommandTimeout?
raybejjani
force-pushed
the
ci-fqdn-initial-dns-retry
branch
from
bed68f5
to
7da61ac
Compare
|
test-gke K8sFQDNTest.* |
|
test-focus K8sFQDNTest.* |
|
build fails because of |
We target jenkins.cilium.io and vagrant-cache.ci.cilium.io as the remote targets for the FQDN tests. Sometimes, the DNS lookups fail and so does the test. We now retry for 30 seconds. When your DNS lookup at first doesn't succeed, try try again. Signed-off-by: Ray Bejjani <ray@isovalent.com>
raybejjani
force-pushed
the
ci-fqdn-initial-dns-retry
branch
from
7da61ac
to
307fb59
Compare
|
test-focus K8sFQDNTest.* |
|
test-gke K8sFQDNTest.* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We target jenkins.cilium.io and vagrant-cache.ci.cilium.io as the remote
targets for the FQDN tests. Sometimes, the DNS lookups fail and so does
the test. We now retry for 30 seconds. When your DNS lookup at first
doesn't succeed, try try again.