Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for file based authorizer for Azure #10876

Merged
merged 1 commit into from Apr 8, 2020
Merged

Add support for file based authorizer for Azure #10876

merged 1 commit into from Apr 8, 2020

Conversation

ashrayjain
Copy link
Contributor

@ashrayjain ashrayjain commented Apr 7, 2020 •
edited

This adds support for file based credentials when using Azure.

This PR prefers file based first and then falls back to environment based if that fails, but we could also reverse that if that's preferable.

Upstream Azure docs for file based auth live here: https://docs.microsoft.com/en-us/azure/developer/go/azure-sdk-authorization#use-file-based-authentication

@ashrayjain ashrayjain requested a review from a team as a code owner April 7, 2020 14:23
@maintainer-s-little-helper
Copy link

Commit ea92dfe00560795823cc26f4614aa6913643b82d does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 7, 2020
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 7, 2020
@ashrayjain
Add support for file based authorizer for Azure
19f2127 
Signed-off-by: Ashray Jain <ashrayj@palantir.com>
@ashrayjain ashrayjain force-pushed the aj/add-support-for-azure-file branch from ea92dfe to 19f2127 Compare April 7, 2020 14:24
@maintainer-s-little-helper
Copy link

Commit ea92dfe00560795823cc26f4614aa6913643b82d does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@ungureanuvladvictor ungureanuvladvictor added the release-note/misc This PR makes changes that have no direct user impact. label Apr 7, 2020
@ungureanuvladvictor ungureanuvladvictor added area/operator Impacts the cilium-operator component integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Apr 7, 2020
@ungureanuvladvictor
Copy link
Member

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 45.917% when pulling 19f2127 on ashrayjain:aj/add-support-for-azure-file into 5d35686 on cilium:master.

@ungureanuvladvictor
Copy link
Member

// failure does not seem related https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18562/testReport/Suite-k8s-1/18/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

test-me-please

@ungureanuvladvictor
Copy link
Member

restart-ginkgo

vadorovsky
vadorovsky approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tgraf tgraf merged commit 0cf1233 into cilium:master Apr 8, 2020
1.8.0 automation moved this from In progress to Merged Apr 8, 2020
@ashrayjain ashrayjain deleted the aj/add-support-for-azure-file branch April 8, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
area/operator Impacts the cilium-operator component integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ashrayjain @ungureanuvladvictor @coveralls @tgraf @vadorovsky