Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RancherOS to documentation OS compatibility matrix #10881

Merged
merged 1 commit into from Apr 7, 2020
Merged

Add RancherOS to documentation OS compatibility matrix #10881

merged 1 commit into from Apr 7, 2020

Conversation

nathanjsweet
Copy link
Member

@nathanjsweet nathanjsweet commented Apr 7, 2020 •
edited

Signed-off-by: Nate Sweet nathanjsweet@pm.me

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Add RancherOS to documentation OS compatibility matrix

Fixes: #9825

@nathanjsweet nathanjsweet requested a review from a team as a code owner April 7, 2020 18:36
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 7, 2020
@nathanjsweet
Add RancherOS to documentation OS compatibility matrix
b4817e8 
Fixes: #9825

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/add-rancher-to-doc-matrix branch from 0623d12 to b4817e8 Compare April 7, 2020 18:37
@nathanjsweet nathanjsweet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Apr 7, 2020
joestringer
joestringer approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure if there's any nuance on the version where earlier versions might work as well but this was the version that users reported works.

@joestringer joestringer merged commit 650657e into master Apr 7, 2020
1.8.0 automation moved this from In progress to Merged Apr 7, 2020
@joestringer joestringer deleted the pr/nathanjsweet/add-rancher-to-doc-matrix branch April 7, 2020 19:10
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 45.979% when pulling b4817e8 on pr/nathanjsweet/add-rancher-to-doc-matrix into d416ff0 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation Documentation/install/system_requirements.rst
3 participants
@nathanjsweet @coveralls @joestringer