Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove netlink package dependency from the ip package #10885

Merged
merged 1 commit into from Apr 8, 2020
Merged

Remove netlink package dependency from the ip package #10885

merged 1 commit into from Apr 8, 2020

Conversation

nathanjsweet
Copy link
Member

@nathanjsweet nathanjsweet commented Apr 7, 2020 •
edited

Signed-off-by: Nate Sweet nathanjsweet@pm.me

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Remove netlink package dependency from the ip package
so that common code no longer needs to be Linux specific.

Removed  the netlink package dependency from the ip package
to decouple common code from being linux specific.

@nathanjsweet
Remove netlink package dependency from the ip package,
7ef825d 
so that common code no longer needs to be Linux specific.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet requested a review from a team April 7, 2020 22:58
@nathanjsweet nathanjsweet requested a review from a team as a code owner April 7, 2020 22:58
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 7, 2020
@nathanjsweet nathanjsweet added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Apr 7, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 45.97% when pulling 7ef825d on pr/nathanjsweet/decouple-ip-from-netlink into ae5588c on master.

@nathanjsweet
Copy link
Member Author

test-me-please

@nathanjsweet
Copy link
Member Author

test-with-kernel

@joestringer joestringer merged commit dcbdb1e into master Apr 8, 2020
1.8.0 automation moved this from In progress to Merged Apr 8, 2020
@joestringer joestringer deleted the pr/nathanjsweet/decouple-ip-from-netlink branch April 8, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nathanjsweet @coveralls @joestringer