api, daemon: drop unused dependency on github.com/jessevdk/go-flags #10890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package github.com/jessevdk/go-flags is pulled in because the swagger server template (which seems to be based on [0] uses it by default. However, we don't use any of the features of this package, i.e. extracting flag descriptions from struct tags. These options are not exposed as CLI flags directly, but are set using the values from the `option` package. [0] https://github.com/go-swagger/go-swagger/blob/master/generator/templates/server/server.gotmpl Due to this, we end up pulling in an unused dependency. Modify the template accordingly and regenerate code to drop this unused dependency. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
pending-review
kind/cleanup
|
test-me-please |
gandro
approved these changes
Apr 8, 2020
tklauser
added a commit
that referenced
this pull request
Apr 8, 2020
…time/flagext Same case as for commit e63a1d4 ("api, daemon: drop unused dependency on github.com/jessevdk/go-flags"), PR #10890. The package is pulled in because the swagger server template uses it by default. However, we don't use any of the features of this package, thus drop it. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>s
aanm
pushed a commit
that referenced
this pull request
Apr 9, 2020
…time/flagext Same case as for commit e63a1d4 ("api, daemon: drop unused dependency on github.com/jessevdk/go-flags"), PR #10890. The package is pulled in because the swagger server template uses it by default. However, we don't use any of the features of this package, thus drop it. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package github.com/jessevdk/go-flags is pulled in because the
swagger server template (which seems to be based on [0] uses it by
default. However, we don't use any of the features of this package, i.e.
extracting flag descriptions from struct tags. These options are not
exposed as CLI flags directly, but are set using the values from the
optionpackage.[0] https://github.com/go-swagger/go-swagger/blob/master/generator/templates/server/server.gotmpl
Due to this, we end up pulling in an unused dependency. Modify the
template accordingly and regenerate code to drop this unused dependency.
First commit is a preparatory cleanup of a missed conversion in #10158.