Fix hubble metricsServer label in values.yaml #10908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes metricsServer label under hubble in values.yaml file which had a mismatch on configmap.yaml on conditional checks as shown below: .Values.global.hubble.metricsServer Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
|
Please set the appropriate release note label. |
|
@gandro can you check this. |
gandro
approved these changes
Apr 9, 2020
|
test-me-please Edit: VM provisioning errors |
aanm
added
pending-review
release-note/misc
aanm
approved these changes
Apr 9, 2020
|
test-me-please jenkins build was no longer available to check |
|
test-me-please |
1 similar comment
|
test-me-please |
|
There is some connectivity test failures in teh Cilium-Ginkgo-Tests, not sure if this is related to this label change. If not we should allow this to merge. |
|
I'm merging since this is a small change and my main concern was with the generation of helm files which didn't fail on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes metricsServer label under hubble in values.yaml
file which had a mismatch on configmap.yaml on conditional checks
as shown below:
.Values.global.hubble.metricsServer
Signed-off-by: Swaminathan Vasudevan svasudevan@suse.com