Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: Improve command-line usability #10933

Merged
merged 3 commits into from
Apr 15, 2020
Merged

vagrant: Improve command-line usability #10933

merged 3 commits into from
Apr 15, 2020

Commits on Apr 15, 2020

  1. vagrant: Distinct name for net-next VMs 

    Having a distinct name for net-next VMs allows us to switch between
NETNEXT=true and NETNEXT=false without destroying VMs each time. It
should also be possible to run both VMs at the same time.

Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    b116dec View commit details
    Browse the repository at this point in the history

  2. vagrant: Do not require env. varables for all Vagrant cmds 

    Currently, to e.g. destroy a Vagrant VM, it is necessary to set some of
the same options that were used to create it (e.g., K8S, NWORKERS, and
now with the previous commit, NETNEXT). This commit fixes this by always
defining common VM names, so that commands like 'vagrant destroy' or
'vagrant ssh' work without setting env. variables.

Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    dd265d4 View commit details
    Browse the repository at this point in the history

  3. vagrant, test: Accept NETNEXT=1 syntax 

    Document NETNEXT option for the dev. VM and accept NETNEXT=1 syntax for
consistency with other options.

Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    94ed694 View commit details
    Browse the repository at this point in the history